Skip to content

Raise TypeError for with raises(..., match=<non-None falsey value>). #4540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Raise TypeError for with raises(..., match=<non-None falsey value>). #4540

merged 1 commit into from
Dec 13, 2018

Conversation

asottile
Copy link
Member

See #4538

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #4540 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
- Coverage   95.92%   95.92%   -0.01%     
==========================================
  Files         111      111              
  Lines       25119    25123       +4     
  Branches     2449     2449              
==========================================
+ Hits        24096    24098       +2     
- Misses        723      724       +1     
- Partials      300      301       +1
Flag Coverage Δ
#docs 30.06% <100%> (+0.07%) ⬆️
#doctesting 30.06% <100%> (+0.07%) ⬆️
#linting 30.06% <100%> (+0.07%) ⬆️
#linux 95.74% <100%> (-0.01%) ⬇️
#nobyte 92.68% <100%> (ø) ⬆️
#numpy 93.48% <100%> (ø) ⬆️
#pexpect 41.84% <0%> (ø) ⬆️
#py27 94.06% <100%> (ø) ⬆️
#py34 92.18% <100%> (+0.06%) ⬆️
#py35 92.2% <100%> (+0.06%) ⬆️
#py36 92.22% <100%> (+0.06%) ⬆️
#py37 94.12% <100%> (+0.01%) ⬆️
#trial 93.48% <100%> (ø) ⬆️
#windows 94.13% <100%> (ø) ⬆️
#xdist 93.98% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
testing/python/raises.py 93.93% <100%> (+0.18%) ⬆️
src/_pytest/python_api.py 97.42% <100%> (ø) ⬆️
src/_pytest/capture.py 93.66% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af674a...a254ad0. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #4540 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
- Coverage   95.92%   95.92%   -0.01%     
==========================================
  Files         111      111              
  Lines       25119    25123       +4     
  Branches     2449     2449              
==========================================
+ Hits        24096    24098       +2     
- Misses        723      724       +1     
- Partials      300      301       +1
Flag Coverage Δ
#docs 30.06% <100%> (+0.07%) ⬆️
#doctesting 30.06% <100%> (+0.07%) ⬆️
#linting 30.06% <100%> (+0.07%) ⬆️
#linux 95.74% <100%> (-0.01%) ⬇️
#nobyte 92.68% <100%> (ø) ⬆️
#numpy 93.48% <100%> (ø) ⬆️
#pexpect 41.84% <0%> (ø) ⬆️
#py27 94.06% <100%> (ø) ⬆️
#py34 92.18% <100%> (+0.06%) ⬆️
#py35 92.2% <100%> (+0.06%) ⬆️
#py36 92.22% <100%> (+0.06%) ⬆️
#py37 94.12% <100%> (+0.01%) ⬆️
#trial 93.48% <100%> (ø) ⬆️
#windows 94.13% <100%> (ø) ⬆️
#xdist 93.98% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
testing/python/raises.py 93.93% <100%> (+0.18%) ⬆️
src/_pytest/python_api.py 97.42% <100%> (ø) ⬆️
src/_pytest/capture.py 93.66% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af674a...a254ad0. Read the comment docs.

@nicoddemus nicoddemus merged commit e03c1f5 into pytest-dev:master Dec 13, 2018
@asottile asottile deleted the type_error_falsey_match_value branch December 13, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants