getfixturevalue does not correctly declare dependency with the calling fixture

[nicoddemus]

Fix #1895

[codecov]

Codecov Report

Merging #4860 into features will decrease coverage by 0.1%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           features    #4860      +/-   ##
============================================
- Coverage     95.76%   95.66%   -0.11%     
============================================
  Files           113      113              
  Lines         25744    25257     -487     
  Branches       2508     2504       -4     
============================================
- Hits          24655    24162     -493     
- Misses          773      775       +2     
- Partials        316      320       +4

Flag	Coverage Δ
#linux	95.48% <100%> (-0.11%)	⬇️
#osx	93.32% <100%> (ø)	⬆️
#windows	93.6% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
src/_pytest/fixtures.py	97.93% <100%> (-0.3%)	⬇️
testing/python/fixtures.py	99.08% <100%> (ø)
testing/test_modimport.py	81.81% <0%> (-1.52%)	⬇️
testing/code/test_source.py	95.53% <0%> (-1.07%)	⬇️
testing/test_argcomplete.py	68.11% <0%> (-0.9%)	⬇️
testing/test_compat.py	91.13% <0%> (-0.63%)	⬇️
testing/test_skipping.py	97.65% <0%> (-0.57%)	⬇️
src/_pytest/warnings.py	88.88% <0%> (-0.53%)	⬇️
src/_pytest/debugging.py	79.76% <0%> (-0.35%)	⬇️
... and 75 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f97e4...c334adc. Read the comment docs.

[nicoddemus]

Ready for review

[nicoddemus]

This is related to #4871. Any chance @blueyed and/or @asottile could take a look?

[asottile]

[blueyed]

Found some typos, and it should be against master, no?

[nicoddemus]

it should be against master, no?

While it is a bug fix, it does change the teardown order of fixtures, so I want to play safe here and release this on 4.4. 👍