ci: Travis: disable cache by default, only for pre-commit #4881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4881 +/- ##
=========================================
+ Coverage 95.67% 95.7% +0.02%
=========================================
Files 113 113
Lines 25172 25172
Branches 2498 2498
=========================================
+ Hits 24083 24090 +7
+ Misses 767 764 -3
+ Partials 322 318 -4
Continue to review full report at Codecov.
|
For pip the usual http caching should be good enough. This keeps the cache for pre-commit with the linting env for now. Ref: pytest-dev#3502
asottile
approved these changes
Mar 14, 2019
| directories: | ||
| - $HOME/.cache/pip | ||
| - $HOME/.cache/pre-commit | ||
| cache: false |
There was a problem hiding this comment.
Fine if we want to keep it, but I suggest to add a comment like the one you put on the description of this PR for reference. 👍
nicoddemus
approved these changes
Mar 14, 2019
| directories: | ||
| - $HOME/.cache/pip | ||
| - $HOME/.cache/pre-commit | ||
| cache: false |
There was a problem hiding this comment.
Fine if we want to keep it, but I suggest to add a comment like the one you put on the description of this PR for reference. 👍
|
@nicoddemus |
diff --git c/.travis.yml i/.travis.yml
index 750f93f8..ae90401d 100644
--- c/.travis.yml
+++ i/.travis.yml
@@ -147,4 +147,5 @@ notifications:
skip_join: true
email:
- [email protected]
+# For pip the usual http caching should be good enough, cache is used for pre-commit.
cache: false |
|
Oops sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pip the usual http caching should be good enough.
This keeps the cache for pre-commit with the linting env for now.
Ref: #3502
Timings: