config: fix consider_preparse with missing argument to -p #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Mar 21, 2019
| @@ -313,6 +313,8 @@ def test_preparse_args(self, pytestpm): | |||
| assert '"hello123"' in excinfo.value.args[0] | |||
| pytestpm.consider_preparse(["-pno:hello123"]) | |||
|
|
|||
| pytestpm.consider_preparse(["-p"]) | |||
There was a problem hiding this comment.
I suggest to add a comment in the lines "just make sure single -p doesn't blow up"
This is only required after/with 415899d - otherwise argparse ensures there is an argument already.
Codecov Report
@@ Coverage Diff @@
## features #4966 +/- ##
============================================
+ Coverage 68.38% 95.89% +27.5%
============================================
Files 58 113 +55
Lines 12163 25319 +13156
Branches 1994 2496 +502
============================================
+ Hits 8318 24280 +15962
+ Misses 3251 729 -2522
+ Partials 594 310 -284
Continue to review full report at Codecov.
|
blueyed
dismissed
nicoddemus’s stale review
I think a changelog is not required - it was not used without argparse in a release yet.
Oh good point. 👍 |
nicoddemus
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only required after/with 415899d - otherwise argparse ensures
there is an argument already.