Skip to content

tests: ensure cleanup with configs via get_config() #5006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 27, 2019

Also done in test_pluginmanager, although no resource warnings are
there at least.

Fixes #4355.

Also done in test_pluginmanager, although no resource warnings are
there at least.

Fixes pytest-dev#4355.
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #5006 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5006      +/-   ##
==========================================
+ Coverage   95.69%   95.71%   +0.01%     
==========================================
  Files         113      113              
  Lines       25178    25178              
  Branches     2498     2498              
==========================================
+ Hits        24095    24100       +5     
+ Misses        765      763       -2     
+ Partials      318      315       -3
Impacted Files Coverage Δ
src/_pytest/pytester.py 87.14% <100%> (+0.09%) ⬆️
testing/test_config.py 99.62% <100%> (-0.01%) ⬇️
testing/test_pluginmanager.py 100% <100%> (ø) ⬆️
src/_pytest/terminal.py 91.74% <0%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae0286...d17ea7a. Read the comment docs.

@blueyed blueyed merged commit 0ac069d into pytest-dev:master Mar 28, 2019
@blueyed blueyed deleted the capture-clean branch March 28, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants