Automated / semi-automated python3 upgrades #5368
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5368 +/- ##
==========================================
+ Coverage 88.77% 92.88% +4.11%
==========================================
Files 115 114 -1
Lines 25906 25528 -378
Branches 2496 2482 -14
==========================================
+ Hits 22997 23711 +714
+ Misses 2564 1487 -1077
+ Partials 345 330 -15
Continue to review full report at Codecov.
|
|
Why is "coding" removed again? (5e2e6b9) |
|
| from setuptools import setup | ||
|
|
||
| # TODO: if py gets upgrade to >=1.6, | ||
| # remove _width_of_current_line in terminal.py | ||
| INSTALL_REQUIRES = [ | ||
| "py>=1.5.0", | ||
| "six>=1.10.0", |
There was a problem hiding this comment.
Thanks six for your service. 🙇
|
I don't understand why the coverage is reporting uncovered lines... for example, it says here: That |
|
I'm always suspicious of any data that |
|
Hmmm indeed, but I noticed that |
|
Rebased on |
|
no problem, though I would have replayed the commits myself so that ended up in the right one 🤷♂️ |
|
OK I think we are good. Can you go ahead and merge @asottile if you are OK with the PR? |
| @@ -34,7 +34,7 @@ jobs: | |||
| - test $(python -c 'import sys; print("%d%d" % sys.version_info[0:2])') = 37 | |||
|
|
|||
| # Full run of latest supported version, without xdist. | |||
| - env: TOXENV=py37 | |||
| - env: TOXENV=py37 PYTEST_COVERAGE=1 | |||
There was a problem hiding this comment.
We do not need this, do we?
We have py37-xdist with coverage already (at least).
There was a problem hiding this comment.
Not sure, this fixed the coverage on the PR.
There was a problem hiding this comment.
I'd guess it was the rebase that fixed it.
We can revert this and this - after things stabilized a bit.. :)
I split this into separate commits to make it easier to review, rebase, and replay.