Skip to content

[RFC] last-failed: honor args #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RFC] last-failed: honor args #5625

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 18, 2019

Ref: #5624

@blueyed
Copy link
Contributor Author

blueyed commented Jul 19, 2019

Any idea for a good test?
Reproducing #5624 there might change in the future (i.e. not necessary test this anymore).
Let's see what coverage has to say.

@blueyed blueyed mentioned this pull request Aug 7, 2019
Closed
@blueyed
Copy link
Contributor Author

blueyed commented Aug 7, 2019 •
edited
Loading

(A good test might come via #5301 - although that is likely more about not considering tests to be unselected when within args)

blueyed
blueyed commented Aug 15, 2019
View reviewed changes
src/_pytest/cacheprovider.py
if not any(str(abs_path).startswith(x) for x in abs_args):
continue
if abs_path.exists():
result.append(abs_path)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus
This was / feels very ad-hoc, but I fear there is not a better mechanism?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus ping

@blueyed blueyed changed the title WIP: last-failed: honor args [RFC] last-failed: honor args Oct 16, 2019
@pytest-dev pytest-dev deleted a comment from codecov bot Oct 16, 2019
@pytest-dev pytest-dev deleted a comment from codecov bot Oct 16, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Oct 20, 2019

Will add a test using the plugin directly. After #6016 for likely some more "config" refactoring.

@blueyed blueyed closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blueyed