Skip to content

Change report-coverage.sh in attempt to fix Azure #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

nicoddemus
Copy link
Member

Recently sometimes Azure has failed with:

++ curl -s https://codecov.io/bash
bash: /dev/fd/63: No such file or directory

This attempts to fix this by modifying report-coverage.sh slightly.

@nicoddemus nicoddemus requested a review from blueyed September 21, 2019 18:31
Recently sometimes Azure has failed with:

++ curl -s https://codecov.io/bash
bash: /dev/fd/63: No such file or directory

This attempts to fix this by modifying report-coverage.sh slightly.
@nicoddemus nicoddemus force-pushed the fix-coverage-report-azure branch from ce7cea1 to de8fdab Compare September 21, 2019 19:03
@blueyed
Copy link
Contributor

blueyed commented Sep 21, 2019

Isn't it "just" a timeout issue on their end?

@nicoddemus
Copy link
Member Author

Doesn't seem like a timeout issue, more some flaky system settings or something.

@blueyed
Copy link
Contributor

blueyed commented Sep 22, 2019

Yes - the point being that curl returns nothing here etc.

But I see that you've added --retry 3.. 👍

Note that -X gcov -X coveragepy -X search -X xcode -X gcovout could be dropped (not necessary with -f IIRC).

@nicoddemus
Copy link
Member Author

Err not sure what you are suggesting... please feel free to push into this branch with any recomentadtions!

@nicoddemus nicoddemus merged commit 018edf2 into pytest-dev:master Sep 23, 2019
@nicoddemus nicoddemus deleted the fix-coverage-report-azure branch September 23, 2019 15:01
@nicoddemus
Copy link
Member Author

Thanks @blueyed and @bluetech!

@blueyed
Copy link
Contributor

blueyed commented Sep 23, 2019

Just for the record, it still might fail (of course):

+ curl -S -L --retry 3 -s https://codecov.io/bash -o codecov-upload.sh
curl: (7) Failed to connect to codecov.io port 443: Timed out
Bash exited with code '7'.

(https://pytest-dev.visualstudio.com/pytest/_build/results?buildId=2260)

blueyed added a commit to blueyed/pytest that referenced this pull request Sep 23, 2019
This should result in retries of 1+2+4+8+16+32 = 63s.

Ref: pytest-dev#5869 (comment)
blueyed added a commit to blueyed/pytest that referenced this pull request Sep 23, 2019
This should result in retries of 1+2+4+8+16+32 = 63s.

Ref: pytest-dev#5869 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants