Skip to content

Add test to ensure _pytest is warning-clean on import #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Add test to ensure _pytest is warning-clean on import #5904

merged 1 commit into from
Oct 7, 2019

Conversation

asottile
Copy link
Member

@asottile asottile commented Oct 1, 2019

supersedes #4510

@asottile
Copy link
Member Author

asottile commented Oct 1, 2019

from a timing perspective, this test is less worse than I expected:

$ pytest testing/test_meta.py 
============================= test session starts ==============================
platform linux -- Python 3.6.8, pytest-5.2.1.dev5+g9a4c0b991, py-1.8.0, pluggy-0.13.0
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/tmp/x/pytest/.hypothesis/examples')
rootdir: /tmp/x/pytest, inifile: tox.ini
plugins: hypothesis-4.38.1
collected 55 items                                                             

testing/test_meta.py ................................................... [ 92%]
....                                                                     [100%]

============================== 55 passed in 6.04s ==============================

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase so we can get a green CI before merging? Thanks!

@asottile asottile merged commit 271dc7f into pytest-dev:master Oct 7, 2019
@asottile asottile deleted the warnings_v2 branch October 7, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants