Skip to content

main: wrap_session: handle exit.Exception with notify_exception #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 21, 2019

Fixes #6257.
Via blueyed#132.

@blueyed blueyed force-pushed the notify_exception-handle-exit-exc-upstream branch from c104547 to 2344982 Compare November 21, 2019 21:50
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@blueyed blueyed merged commit a7268aa into pytest-dev:master Nov 22, 2019
@blueyed blueyed deleted the notify_exception-handle-exit-exc-upstream branch November 22, 2019 04:49
blueyed added a commit to blueyed/pytest that referenced this pull request Feb 2, 2020
This duplicates code from a7268aa
(pytest-dev#6258), but would otherwise
conflict with
https://github.com/pytest-dev/pytest/blob/eb648ab/src/_pytest/main.py#L209-L211.

In the long run there should be `_wrap_session` likely with
`wrap_session` wrapping it with that exception handling.
blueyed added a commit to blueyed/pytest that referenced this pull request Feb 2, 2020
blueyed added a commit to blueyed/pytest that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

main: wrap_session: does not handle exit.Exception from notify_exception
2 participants