WIP POC RFC: remove config/session as possible parameters for node #6293
Conversation
This comment has been minimized.
This comment has been minimized.
|
@RonnyPfannschmidt do you plan to pick this up after 5.4, or before? |
|
This is 6.1 stuff |
|
I meant the deprecation 😁
|
| parent: Optional["Node"] = None, | ||
| config: Optional[Config] = None, | ||
| session: Optional["Session"] = None, | ||
| parent: Union["Node", "Session"], | ||
| fspath: Optional[py.path.local] = None, | ||
| nodeid: Optional[str] = None, |
There was a problem hiding this comment.
Should we still allow to customize the entire node id?
I know there are items which are derived from other items, for example flake8 items which are derived from normal Python items, but those can be customized by passing a different name already.
There was a problem hiding this comment.
actualy an oversight, we should also disallow it quickly for from_parent
There was a problem hiding this comment.
my main intend with this pr was the structural details, so nodeid was not instrumental to the data structure
There was a problem hiding this comment.
I see.
So the main intent is to remove, in 6.1, config, session and nodeid from the Node constructor, as I understand they are the cause of structural problems, correct?
|
closing until i pick up again to clean clutter, its linked in the Node cleanup project |
this removes the ability to pass session/config to nodes directly, and in turn exposes a few breakages in hierarchy we implicitly allowed (but shouldn't have to begin with)
I'll work out details of deprecation and moving to this later