Skip to content

Deprecation policy - insert considerations for breaking changes #6298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RonnyPfannschmidt
Copy link
Member

we have a number of structural changes ahead in Node Structure, fixture internals, as well as many other detail api's

as such i wanted to propose a update to our deprecation policy that enables sorting those out in a coordinated way when transitional apis are not sustainable.

@RonnyPfannschmidt RonnyPfannschmidt changed the base branch from master to features December 1, 2019 11:49
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for putting this together @RonnyPfannschmidt!

@nicoddemus
Copy link
Member

Do you plan to get this into 5.4 or only in the next major release?

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good -- I'll take a second pass after more of the other reviews have been settled (I had a hard time reading it without being distracted hehe)

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus i'd like to get this into 5.4, but enact it starting with 6.0

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor things

@RonnyPfannschmidt RonnyPfannschmidt changed the title [WIP][RFC] Deprecation policy - insert considerations for breaking changes [OPMERGES][RFC] Deprecation policy - insert considerations for breaking changes Dec 7, 2019
@RonnyPfannschmidt
Copy link
Member Author

i'll squash before merging myself

@RonnyPfannschmidt
Copy link
Member Author

@asottile would you like another look, i'm going to squash soon and go for a merge then

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-Authored-By: Anthony Sottile <[email protected]>
Co-Authored-By: Bruno Oliveira <[email protected]>
Co-Authored-By: Hugo van Kemenade <[email protected]>
@RonnyPfannschmidt RonnyPfannschmidt changed the title [OPMERGES][RFC] Deprecation policy - insert considerations for breaking changes Deprecation policy - insert considerations for breaking changes Dec 7, 2019
@RonnyPfannschmidt RonnyPfannschmidt merged commit 30f2729 into pytest-dev:features Dec 7, 2019
@RonnyPfannschmidt RonnyPfannschmidt deleted the deprecation-breakage branch December 7, 2019 18:50
@RonnyPfannschmidt
Copy link
Member Author

thanks everyone for chiming in and helping out to make this one nice 👍

@nicoddemus
Copy link
Member

I think we should announce this somehow, would you like to post this on Twitter @RonnyPfannschmidt?

@nicoddemus
Copy link
Member

I just realized this went to features... shouldn't we publish this right away?

@RonnyPfannschmidt
Copy link
Member Author

It's intentionally there, the next and possible last feature branch feature release is close

@nicoddemus
Copy link
Member

Cool.

Btw can your review your action items for 6.0? I suspect the ones there created by you won't be ready for 6.0 and will need to be postponed.

@RonnyPfannschmidt
Copy link
Member Author

Will take a look after travel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants