-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Deprecation policy - insert considerations for breaking changes #6298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation policy - insert considerations for breaking changes #6298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for putting this together @RonnyPfannschmidt!
Do you plan to get this into 5.4 or only in the next major release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good -- I'll take a second pass after more of the other reviews have been settled (I had a hard time reading it without being distracted hehe)
@nicoddemus i'd like to get this into 5.4, but enact it starting with 6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor things
i'll squash before merging myself |
@asottile would you like another look, i'm going to squash soon and go for a merge then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Anthony Sottile <[email protected]> Co-Authored-By: Bruno Oliveira <[email protected]> Co-Authored-By: Hugo van Kemenade <[email protected]>
7d64f7f
to
3812985
Compare
thanks everyone for chiming in and helping out to make this one nice 👍 |
I think we should announce this somehow, would you like to post this on Twitter @RonnyPfannschmidt? |
I just realized this went to |
It's intentionally there, the next and possible last feature branch feature release is close |
Cool. Btw can your review your action items for 6.0? I suspect the ones there created by you won't be ready for 6.0 and will need to be postponed. |
Will take a look after travel |
we have a number of structural changes ahead in Node Structure, fixture internals, as well as many other detail api's
as such i wanted to propose a update to our deprecation policy that enables sorting those out in a coordinated way when transitional apis are not sustainable.