Fix node ids which contain a parametrized empty-string variable #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

asottile merged 1 commit into pytest-dev:features from asottile:empty_string_parametrize_nodeid

Jan 29, 2020

Member

asottile commented Jan 28, 2020 •

edited

Loading

I went with features as this changes the node ids -- I could target master instead if this is desirable as a bugfix.

partially fixes #6597


          Fix node ids which contain a parametrized empty-string variable

abd5fc8

asottile mentioned this pull request

Progression is wrong when using empty string in parametrized tests #6597

Open

Contributor

blueyed commented Jan 29, 2020

LGTM, but typically it is called "nodeids".

RonnyPfannschmidt approved these changes

View reviewed changes

asottile merged commit 595d62b into pytest-dev:features

asottile deleted the empty_string_parametrize_nodeid branch

January 29, 2020 16:42

RonnyPfannschmidt mentioned this pull request

"Empty id" mechanism in callspec #8155

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet