Skip to content

Reword fixture docs for clarity #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

Reword fixture docs for clarity #6627

merged 1 commit into from
Jan 30, 2020

Conversation

DanielArndt
Copy link
Contributor

I stumbled over the wording here a bit, and I thought this would make it read a little easier.

I'm not sure if I need a changelog entry for this. Obviously, there is no issue to attribute it to. Let me know if that is necessary.

@DanielArndt
Copy link
Contributor Author

I'm not a linguist, but alternatively "Not only can fixtures be used in test functions, but fixture functions can use other fixtures themselves".

nicoddemus
nicoddemus approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it looks better, thanks!

You are right, small adjustments to the docs in general don't need a CHANGELOG entry.

Thanks again! 👍

@nicoddemus nicoddemus merged commit be18f85 into pytest-dev:master Jan 30, 2020
@DanielArndt DanielArndt deleted the fixture-docs-reword-for-clarity branch January 30, 2020 15:59
@hugovk hugovk mentioned this pull request Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielArndt @nicoddemus