Skip to content

Inline FunctionMixin with Function #6664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2020
Merged

Inline FunctionMixin with Function #6664

merged 3 commits into from
Feb 3, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 3, 2020

Generator was removed in 7eb28f9, and this pleases mypy to correctly
complain that FunctionMixin has no config (within
_prunetraceback).

@blueyed
Inline FunctionMixin with Function
19c92b5 
`Generator` was removed in 7eb28f9, and this pleases mypy to correctly
complain that `FunctionMixin` has no `config` (within
`_prunetraceback`).
@blueyed
typing: _prunetraceback
2343f70
@blueyed
minor
5be918c
@blueyed
Copy link
Contributor Author

blueyed commented Feb 3, 2020

codecov/patch — 96.66% of diff hit (target 96.8%)

Will not cover that here likely, but likely later when fixing _prunetraceback (likely related to #6657).

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice followup

@blueyed blueyed merged commit 8ec4d03 into pytest-dev:features Feb 3, 2020
@blueyed blueyed deleted the rm-FunctionMixin branch February 3, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @RonnyPfannschmidt