#6289: Add new example to XFAIL documentation #6685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6289 Add new XFAIL docs example
|
@graingert or @nicoddemus would one of you please help me understand the failing codecov test? I've tried to grok the details/output on the codecov page. Unless I'm mistaken, I believe I've only edited files that aren't even tracked by codecov. Is this correct? |
|
@nathanielcompton Don't worry about this check, it's a little touch-and-go. Since you don't change any code, only docs, you should ignore it in this PR. |
bluetech
reviewed
Feb 14, 2020
Update documentation from PR feedback
|
@nicoddemus and @bluetech : Ready for re-review when you get time. Thanks for the good feedback. |
bluetech
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Thanks @nathanielcompton, it looks good to me now, except two minor nits.
Co-Authored-By: Ran Benita <[email protected]>
Co-Authored-By: Ran Benita <[email protected]>
nicoddemus
approved these changes
Feb 19, 2020
|
Thanks @bluetech and @nathanielcompton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussions linked in open issue #6289 , I added an additional example to the
xfaildocumentation.