Skip to content

doc for _capturing_for_request #6698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

doc for _capturing_for_request #6698

merged 1 commit into from
Feb 13, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 9, 2020 •
edited
Loading

Follow-up to #6663.

@blueyed blueyed changed the title doc: add docstring for CaptureManager._capturing_for_request Factor out _capturing_for_request into a function, doc Feb 9, 2020
@blueyed blueyed changed the base branch from features to master February 12, 2020 15:08
bluetech
bluetech reviewed Feb 12, 2020
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An argument in favor of keeping it inside the CaptureManager class is that it sets and accesses internal details of CaptureManager, and is basically its "heart", so and it's nice to have it encapsulated.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 12, 2020 •
edited
Loading

An argument in favor of keeping it inside the CaptureManager class is that it sets and accesses internal details of CaptureManager, and is basically its "heart", so and it's nice to have it encapsulated.

Makes sense. The main motivation was to have less (duplicated) boilerplate code mainly.

Pulled 5cd2214 out.

@blueyed @bluetech
doc: add docstring for CaptureManager._capturing_for_request
3d97531 
Based on the removed doc for `_install_capture_fixture_on_item`.

Follow-up to pytest-dev#6663.

Update src/_pytest/capture.py  [ci skip]

Co-Authored-By: Ran Benita <[email protected]>
@blueyed blueyed changed the title Factor out _capturing_for_request into a function, doc doc for _capturing_for_request Feb 12, 2020
nicoddemus
nicoddemus approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@blueyed blueyed merged commit 07b7b6f into pytest-dev:master Feb 13, 2020
@blueyed blueyed deleted the doc branch February 13, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blueyed @nicoddemus @bluetech