WIP: An assortment of type annotations #6717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2020
Merged
|
OK, all extracted (see references above). |
|
@bluetech thanks for undertaking this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6556.
This PR adds annotations to several hookspecs and their implementations, and also to several classes and related types/functions (
FixtureManager,FuncFixtureInfo,FixtureRequest,SubRequest,ParameterSet,param(),CallSpec2,Metafuncand others). Some stuff was hard to decipher but I tried my best :)I'll be working on cleaning it and and split it into multiple PRs, but feel free to leave comments.
There are some code-level changes hidden in there, although I tried to minimize that. I'll make sure to submit them separately.