Skip to content

pytester: LineMatcher: use _fail with _match_lines_random #6747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

pytester: LineMatcher: use _fail with _match_lines_random #6747

merged 1 commit into from
Feb 19, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 15, 2020

No description provided.

@bluetech
Copy link
Member

I am not very familiar with this but from what I can understand this makes sense.

get_lines_after also raises ValueError, should it be changed as well?

@blueyed
Copy link
Contributor Author

blueyed commented Feb 16, 2020

get_lines_after also raises ValueError, should it be changed as well?

It's not really used for validation/asserting itself, so a ValueError there makes sense still.

@blueyed blueyed merged commit 4021770 into pytest-dev:master Feb 19, 2020
@blueyed blueyed deleted the lm-use-_fail branch February 19, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blueyed @bluetech @nicoddemus