Skip to content

Handle match with pytest.raises() #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 22, 2020
Merged

Handle match with pytest.raises() #6753

merged 7 commits into from
Feb 22, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 17, 2020 •
edited
Loading

TODO:

  • changelog rephrasing

Fixes #6752.

RonnyPfannschmidt
RonnyPfannschmidt previously requested changes Feb 17, 2020
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as i can tell this change elevates a bug (not passing match to the function) to a breaking api change

@blueyed blueyed closed this Feb 17, 2020
@blueyed blueyed deleted the raises-match-func branch February 17, 2020 14:01
@blueyed blueyed mentioned this pull request Feb 17, 2020
Closed
@RonnyPfannschmidt
Copy link
Member

@nicoddemus #5529 as far as i can tell introduced the bug and i missed it back then

@blueyed blueyed restored the raises-match-func branch February 17, 2020 14:19
@blueyed blueyed reopened this Feb 17, 2020
blueyed added a commit to blueyed/pytest that referenced this pull request Feb 17, 2020
@blueyed
fix pytest-raises-match test
49369ab 
Ref: pytest-dev#6753
blueyed
blueyed commented Feb 17, 2020
View reviewed changes
bluetech
bluetech reviewed Feb 17, 2020
View reviewed changes
@blueyed blueyed mentioned this pull request Feb 18, 2020
Closed
1 task
nicoddemus
nicoddemus approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blueyed!

@blueyed
Copy link
Contributor Author

blueyed commented Feb 22, 2020

Rebased and fixed the typing in 37a283b.

@blueyed blueyed requested a review from bluetech February 22, 2020 13:04
bluetech
bluetech approved these changes Feb 22, 2020
View reviewed changes
@blueyed blueyed mentioned this pull request Feb 22, 2020
Merged
1 task
@blueyed blueyed merged commit c8b4a1a into pytest-dev:master Feb 22, 2020
@blueyed blueyed deleted the raises-match-func branch February 22, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

@nicoddemus nicoddemus nicoddemus approved these changes

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"match" ignored with pytest.raises(Exc, func, match=…)
4 participants
@blueyed @RonnyPfannschmidt @nicoddemus @bluetech