-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[4.6.x] Fix one issue for compat::getfuncargnames #6785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.6.x] Fix one issue for compat::getfuncargnames #6785
Conversation
…funcargnames because it is already removed from signature(function)
…funcargnames because it is already removed from signature(function)
…funcargnames because it is already removed from signature(function)
@nicoddemus I don't think the CI failure was introduced by my change. Could you help me with this please? |
Travis seems to fail with tmpdir cleanup |
…funcargnames because it is already removed from signature(function)
I've edited the title to add |
@SeanXu1984 - it looks like this issue also affects the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as i can tell this one tries to add bound methods, which is not something pytest itself collects
we need a accompanying unit-test at least and a reference for the usage, else its bound to cause confusion later on
also in order to be integrated properly we need it as feature in master and do a back-port later on
I've created another PR for main branch. #6882 |
Closing for now as in #6882. 👍 |
Fix so the self of an instancemethod will not be removed again in getfuncargnames because it is already removed from signature(function)
I will deal with changelog later.