cacheprovider: speed up NFPlugin when --nf is not enabled #7130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to the O(n^2), as N grows the slowness becomes more pronounced, e.g. changing 5000 -> 50000, the difference becomes 9.5s vs. 35.5s. cc @boxed -- thought I'd let you know about performance fixes, let me know if you don't want me to. |
bluetech
force-pushed
the
cacheprovider-nf-set
branch
from
0441d2a to
3495a6e
Compare
|
Thanks for the notification. I absolutely want you to! |
The code used an O(n^2) loop. Replace list with set to make it O(n).
For backward compatibility the filesystem cache still remains a list.
On this test:
import pytest
@pytest.mark.parametrize("x", range(5000))
def test_foo(x): pass
run with `pytest --collect-only`:
Before: 0m1.251s
After: 0m0.921s
bluetech
force-pushed
the
cacheprovider-nf-set
branch
from
3495a6e to
4a42afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used an O(n^2) loop. Replace list with set to make it O(n).
For backward compatibility the filesystem cache still remains a list.
On this test:
run with
pytest --collect-only:Before: 0m1.251s
After: 0m0.921s