Skip to content

Fix exception causes all over the codebase #7387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2020
Merged

Fix exception causes all over the codebase #7387

merged 1 commit into from
Jun 21, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 19, 2020

This is a continuation of #7351

  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.
  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order.

@cool-RR cool-RR force-pushed the 2020-06-11-raise-from branch from 7df30fb to 48d6021 Compare June 19, 2020 19:01
@cool-RR cool-RR force-pushed the 2020-06-11-raise-from branch from 48d6021 to dd446be Compare June 19, 2020 19:03
nicoddemus
nicoddemus approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 21, 2020

@bluetech Nudge

@bluetech bluetech merged commit 83891d9 into pytest-dev:master Jun 21, 2020
@bluetech
Copy link
Member

Thanks @cool-RR! I do hope you won't be angry if at some point we change a bunch of these to from None :)

@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 21, 2020

@bluetech Hey, I'm happy that my opinion against from None is respected, that's the best I can ask for.

@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 24, 2020

I just made a blog post about this change here: https://blog.ram.rachum.com/post/621791438475296768/improving-python-exception-chaining-with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cool-RR @bluetech @nicoddemus