Skip to content

Handle reports that don't have a reprcrash #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2015
Merged

Handle reports that don't have a reprcrash #781

merged 1 commit into from
Jun 17, 2015

Conversation

punya
Copy link
Contributor

@punya punya commented Jun 16, 2015

Closes #713 (which happens because ReprFailDoctest doesn't have a reprcrash)

@nicoddemus
Copy link
Member

Thanks for PR! 😄

Some requests:

  • Can you also add a test for this fix? Take a look at testing/test_doctest.py for examples, seems simple to create a test for the issue;
  • Add yourself to CONTRIBUTORS;
  • Add a note about this in the CHANGELOG;

If by any chance you don't have the time to work on this, please let me know.

@punya
Copy link
Contributor Author

punya commented Jun 16, 2015

I don't see a CONTRIBUTORS file - could you point me to the right location?

@nicoddemus
Copy link
Member

Sorry, I meant AUTHORS. 😅

Closes #713 (which happens because ReprFailDoctest
doesn't have a reprcrash)
@punya
Copy link
Contributor Author

punya commented Jun 17, 2015

@nicoddemus, it looks like the AppVeyor build is stuck. Thoughts on how to proceed?

@nicoddemus
Copy link
Member

Actually it didn't even start yet, but I just tested your patch on Windows and it is OK, so I'm merging it.

Thanks again for the PR!

@nicoddemus nicoddemus merged commit 0b0406f into pytest-dev:master Jun 17, 2015
@punya
Copy link
Contributor Author

punya commented Jun 17, 2015

When can I expect to see a release containing this change? Should I backport it to the 2.7 branch?

@nicoddemus
Copy link
Member

I'm don't know about a release date yet. I will backport it to the 2.7 branch myself, thanks.

@punya
Copy link
Contributor Author

punya commented Jun 17, 2015

Thanks for explaining, and for your quick turnaround on the PR :)

@nicoddemus
Copy link
Member

Thanks again for the PR, Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants