-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[WIP] py36 plus #7811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] py36 plus #7811
Conversation
I know this is WIP, but FWIW I think you can also remove |
https://pypi.org/project/com2ann/ might help. |
yeah the problem is a good percentage of them have some things that need manual attention (I started with com2ann and then said "maybe later"):
=>
|
I'm going to be splitting this out into a bunch of PRs so this is easier to merge -- right now it's going to be a real pain to keep rebasing / managing conflicts as I finish things up 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems to combine lots of unrelated changes, but overall it seems that most of it is around adding fstrings and type checking.
I would totally support smaller steps of atomic changes, like remove py35 jobs and update python_requires, followed by update pre-commit linters.
@ssbarnea did you not read my last comment? |
Yep, but after I added the comment. |
still TODO:
TYPE_CHECKING