Skip to content

Colon-pair keywords #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

pakal
Copy link

@pakal pakal commented Jun 28, 2015

@pakal
Copy link
Author

pakal commented Jun 30, 2015

OK my bad, python2.6 doesn't accept re.sub(..., flags=xxx) argument.
I'll change it to "re.sub("(?i)mr", "", "Mr Bean")" notation asap and update the PR.

@nicoddemus
Copy link
Member

Related to #765

@flub
Copy link
Member

flub commented Jul 21, 2015

So continuing the conversation from the original bitbucket PR, does it help if -k understands the node-id? The whole point of the node-id was that it could be copy-pasted, partially copy-pasting it seems like a weird use-case and increases the backwards-compatibility someone who'd like to tackle the python keywords issue with -k would have to worry about.

@RonnyPfannschmidt
Copy link
Member

I'm -1 on this one, test ids can be passed without -k

@RonnyPfannschmidt
Copy link
Member

Imho We should support exact full name prefix matching and regex matching via the planned keyword expressions

@nicoddemus
Copy link
Member

I was +1 on the PR until I found out that you can actually copy/paste ids directly, but now I must say I'm +0 on it as I agree with @flub's points.

@RonnyPfannschmidt
Copy link
Member

we should take a look at partial test id's for the following use-case:

-> run all parametrizations of a test functions

@flub
Copy link
Member

flub commented Jul 22, 2015

But as part of -k? I think that should be part of the normal test id
parameter so remain -1 on this
On 22 Jul 2015 19:55, "Ronny Pfannschmidt" [email protected] wrote:

we should take a look at partial test id's for the following use-case:

-> run all parametrizations of a test functions


Reply to this email directly or view it on GitHub
#806 (comment).

@RonnyPfannschmidt
Copy link
Member

yes, it should be part of the test id selection

i suspect a reorganization of collection<>parametrisation will do some good,
but thats potentially for pytest 3.0

@flub
Copy link
Member

flub commented Jul 24, 2015

So it seems like the consensus is that selection by ID is already suitably covered and should not be done by -k. Thanks for submitting the pull requests anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants