migrates test_warnings.py from testdir to pytester #8104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
reviewed
Dec 6, 2020
There was a problem hiding this comment.
Thanks @bot2x, looks good to me!
One thing that would also be nice, while we're at it, is to add -> None to the test functions. I made one suggestion in the GitHub review but it also applies to the other places.
The reason for adding -> None is that without it mypy still considers the type annotations to be partial.
But it's also good without it, let me know if you can't get to it.
testing/test_warnings.py
Outdated
| @@ -39,9 +39,9 @@ def foo(): | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings("default") | |||
| def test_normal_flow(testdir, pyfile_with_warnings): | |||
| def test_normal_flow(pytester: Pytester, pyfile_with_warnings): | |||
There was a problem hiding this comment.
Suggested change
| def test_normal_flow(pytester: Pytester, pyfile_with_warnings): | |
| def test_normal_flow(pytester: Pytester, pyfile_with_warnings) -> None: |
There was a problem hiding this comment.
Understood. This is to be added to all the function which don't return anything for the completeness. I'll update the pr.
bluetech
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.