Remove outdated docs about pytest.warns and DeprecatedWarning #8754
Conversation
nicoddemus
added
the
needs backport
testing/test_warnings.py
Outdated
| Check that recwarn can capture DeprecationWarning by default | ||
| without custom filterwarnings (see #8666). | ||
| """ | ||
| pytester.makepyfile( |
There was a problem hiding this comment.
I think this test should be inside test_recwarn.py?
also I don't think pytester is needed here -- this can be tested directly (?)
the testsuite is failing because this test function name matches test_recwarn.py
There was a problem hiding this comment.
Good points, all done.
I initially used pytester to ensure our own warning filters wouldn't interfere with the test, but in the end I'm not sure it is needed after all.
Since pytest-dev#2908, the user doesn't need to set warning filters to capture `DeprecationWarning` with `pytest.warns`. Fix pytest-dev#8666
nicoddemus
force-pushed
the
fix-deprecation-docs
branch
from
36dce60 to
84c5fe4
Compare
src/_pytest/tmpdir.py
Outdated
| @@ -131,8 +131,8 @@ def getbasetemp(self) -> Path: | |||
| # rootdir's permissions. Historically 0o755 was used, so we can't | |||
| # just error out on this, at least for a while. | |||
| if hasattr(os, "getuid"): | |||
| uid = os.getuid() # type:ignore[attr-defined] | |||
There was a problem hiding this comment.
This was done in a separate commit (84c5fe4).
There was a problem hiding this comment.
I think the hasattr check should be if sys.platform != 'win32' -- this matches the guard from typeshed: https://github.com/python/typeshed/blob/48a346920bbc24165bd9e9cf29a2b5140eae2abc/stdlib/os/__init__.pyi#L388
There was a problem hiding this comment.
Agree, thanks. Updated. 👍
This matches the guard used by typeshed and avoid mypy errors on Windows: https://github.com/python/typeshed/blob/48a346920bbc24165bd9e9cf29a2b5140eae2abc/stdlib/os/__init__.pyi#L388
nicoddemus
force-pushed
the
fix-deprecation-docs
branch
from
84c5fe4 to
16685dc
Compare
|
Backport: #8755 |
[6.2.x] Merge pull request #8754 from nicoddemus/fix-deprecation-docs
nicoddemus
added
backported
and removed
needs backport
Since #2908, the user doesn't need to set warning filters to capture
DeprecationWarningwithpytest.warns.Fix #8666