-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
closes #8824 Changelog rewording for 7.0 #8826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
268761d
fixed changelog/*.rst docs
ericluoliu f0033b8
add author name
ericluoliu d41850e
fixed-documents
ericluoliu 96c787f
fix issue 8761 doc
ericluoliu e38d35a
fix issue 8645 doc
ericluoliu f13f150
fix issue 8447 doc
ericluoliu a8e720d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Raising :class:`unittest.SkipTest` to skip collection of tests during the | ||
pytest collection phase is deprecated. Use :func:`pytest.skip` instead. | ||
|
||
Note: This deprecation only relates to using `unittest.SkipTest` during test | ||
Note: This deprecation only relates to using :class:`unittest.SkipTest` during test | ||
collection. You are probably not doing that. Ordinary usage of | ||
:class:`unittest.SkipTest` / :meth:`unittest.TestCase.skipTest` / | ||
:func:`unittest.skip` in unittest test cases is fully supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
Internal Restructure: let python.PyObjMixing inherit from nodes.Node to carry over typing information. | ||
Internal Restructure: let ``python.PyObjMixin`` inherit from ``nodes.Node`` to carry over typing information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
Several behaviors of :meth:`Parser.addoption <pytest.Parser.addoption>` are now | ||
scheduled for removal in pytest 7 (deprecated since pytest 2.4.0): | ||
scheduled for removal in pytest 8 (deprecated since pytest 2.4.0): | ||
|
||
- ``parser.addoption(..., help=".. %default ..")`` - use ``%(default)s`` instead. | ||
- ``parser.addoption(..., type="int/string/float/complex")`` - use ``type=int`` etc. instead. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
Defining a custom pytest node type which is both an item and a collector now issues a warning. | ||
Defining a custom pytest node type which is both an :class:`pytest.Item <Item>` and a :class:`pytest.Collector <Collector>` now issues a warning. | ||
It was never sanely supported and triggers hard to debug errors. | ||
|
||
Instead, a separate collector node should be used, which collects the item. See :ref:`non-python tests` for an example. |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
Fixed issue where `TestCase.setUpClass` is not called when a test has `/` in its name since pytest 6.2.0. | ||
Fixed issue where :meth:`unittest.TestCase.setUpClass` is not called when a test has `/` in its name since pytest 6.2.0. | ||
|
||
This refers to the path part in pytest node IDs, e.g. `TestClass::test_it` in the node ID `tests/test_file.py::TestClass::test_it`. | ||
This refers to the path part in pytest node IDs, e.g. ``TestClass::test_it`` in the node ID ``tests/test_file.py::TestClass::test_it``. | ||
|
||
Now, instead of assuming that the test name does not contain ``/``, it is assumed that test path does not contain ``::``. We plan to hopefully make both of these work in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
:func:`pytest.warns(None) <pytest.warns>` is now deprecated because many people used | ||
it to mean "this code does not emit warnings", but it actually had the effect of | ||
checking that the code emits at least one warning of any type - like ``pytest.warns()`` | ||
or ``pytest.warns(Warning)``. |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, no need to worry about ` vs `` because we configure the docs so they are equivalent:
pytest/doc/en/conf.py
Lines 102 to 103 in 5016375
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should still be consistent though - right now we use an odd mix of both...
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, just mentioning that to clarify that is not necessary to go hunting for those, unless inclined to spend time on it for consistency reasons, because otherwise the end result is the same.