Skip to content

mark/structures: slightly optimize some functions #9152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Oct 2, 2021

normalize_mark_list shows up in pandas collection profiles. It's simple enough to improve.

`normalize_mark_list` shows up in pandas collection profiles. It's
simple enough to improve.
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good,
should we plan to add some micro benchmarks for this type of thing?

@bluetech
Copy link
Member Author

bluetech commented Oct 2, 2021

should we plan to add some micro benchmarks for this type of thing?

Will be nice to set up some benchmark suite which can be periodically run to find regressions, or to evaluate perf changes. I might work on it when I have some time.

@bluetech bluetech merged commit 0fbfd1c into pytest-dev:main Oct 2, 2021
@bluetech bluetech deleted the mark-optimize branch October 4, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants