-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add colors to summary #9875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colors to summary #9875
Conversation
7efcfde
to
bcaff45
Compare
cc @ssbarnea |
@nicoddemus LOL! I did not expect anyone to react so quickly on my suggestion. I was waiting for some feedback, imagining that I will have to make it myself. Not a complaint. I love it! And is it obvious from the photo how much easier is to read. My vote is for first option, I personally dislike bold on terminal because it makes the shape of the letters harder to read, some terminals do not even support bold. Using default text color is good here. If you use vscode, you might also be interested about microsoft/vscode#147769 -- i was bit engaged with microsoft on making the terminal links easier to click as sometimes it fails to open the files. |
Hehehe got some time to work on pytest and seemed like a nice improvement to tackle in a couple of hours.
We can use another color for the test names too. |
I think this is nice, 👍. BTW, here is the output of a JavaScript test runner called jest: Two relevant things:
|
Yeah we can probably use that more. 👍 |
2d299c2
to
3e07127
Compare
I somewhat like the bold, and jest uses it too. I'll leave it to you to decide :) |
Some things need to hit the market. If it proves less than ideal, we will see others complaining. Anyway thanks for the improvements! |
[0] Original output, for comparison:
[1] Coloring status words:
Note that here I also moved the XFAIL reason to the same line, similar to the summary we have for failures. I think this is more pleasing, and was implemented when we didn't have the failure summary on each line, and not updated as an oversight.
[2] Test names in bold:
Fix #9873
I personally like [2], but posting [1] in case people prefer it.
The fact that SKIPS are formatted differently and also folded together bothers me a bit, opened #9876 for discussion.