Add timezone support for cron jobs #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
=======================================
Coverage 98.79% 98.80%
=======================================
Files 9 9
Lines 916 917 +1
Branches 166 166
=======================================
+ Hits 905 906 +1
Misses 6 6
Partials 5 5
Continue to review full report at Codecov.
|
iamlikeme
force-pushed
the
cron-timezone
branch
from
946191e to
d431d9f
Compare
iamlikeme
force-pushed
the
cron-timezone
branch
from
d431d9f to
bdaea25
Compare
|
This is great, thanks so much. |
|
I spent a long time trying to get it to yield an incorrect timezone e.g. using pytz, but it seems your logic is correct. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset ensures that calculations of execution time for cron jobs are done on timezone-aware datetime objects. Timezone can be specified by a new
Workerattributetimezonewhich defaults to the system timezone (which preserves the current behavior).Fixes: #351