Skip to content

Tolerate missing reason phrases #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2017
Merged

Tolerate missing reason phrases #32

merged 1 commit into from
Feb 28, 2017

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Feb 28, 2017

Lukasa
Lukasa approved these changes Feb 28, 2017
View reviewed changes
Copy link
Member

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this LGTM. It's sad and stupid, but looks good.

@codecov
Copy link

codecov bot commented Feb 28, 2017 •
edited
Loading

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #32   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         898    900    +2     
  Branches      171    172    +1     
=====================================
+ Hits          898    900    +2
Impacted Files Coverage Δ
h11/tests/test_io.py 100% <ø> (ø) ✅
h11/_abnf.py 100% <ø> (ø) ✅
h11/_readers.py 100% <100%> (ø) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392c1d1...84ec638. Read the comment docs.

@njsmith
Copy link
Member Author

njsmith commented Feb 28, 2017

'kay, I'm going to merge this and then pretend it never happened.

@njsmith njsmith merged commit 6071491 into master Feb 28, 2017
@njsmith njsmith deleted the missing-reason-phrase branch February 28, 2017 14:13
@njsmith njsmith mentioned this pull request Jun 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njsmith @Lukasa