Skip header validation for data parsed off the wire #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 21
Lines 904 908 +4
Branches 173 175 +2
=====================================
+ Hits 904 908 +4
Continue to review full report at Codecov.
|
The parser already validates, so there's no need to do it twice, and it's a bit expensive. On my laptop, on the benchmark in bench/, I get: CPython 3.5: ~4386 req/sec -> ~5141 req/sec = 17% speedup PyPy 5.6.0: ~19311 req/sec -> ~21106 req/sec = 9% speedup
njsmith
force-pushed
the
reduce-double-checking
branch
from
fcf6a36 to
022dd88
Compare
pquentin
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser already validates, so there's no need to do it twice, and
it's a bit expensive.
On my laptop, on the benchmark in bench/, I get:
CPython 3.5: ~4386 req/sec -> ~5141 req/sec = 17% speedup
PyPy 5.6.0: ~19311 req/sec -> ~21106 req/sec = 9% speedup