Skip to content

Raise for status when fetching w/ requests #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Raise for status when fetching w/ requests #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jsonschema/tests/test_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2323,5 +2323,8 @@ class _ReallyFakeJSONResponse:

_response = attr.ib()

def raise_for_status(self):
return None

def json(self):
return json.loads(self._response)
4 changes: 3 additions & 1 deletion jsonschema/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,9 @@ def resolve_remote(self, uri):
elif scheme in ["http", "https"] and requests:
# Requests has support for detecting the correct encoding of
# json over http
result = requests.get(uri).json()
response = requests.get(uri)
response.raise_for_status()
result = response.json()
else:
# Otherwise, pass off to urllib and assume utf-8
with urlopen(uri) as url:
Expand Down