Skip to content

Fix mock import in Python 3.x #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Conversation

felixonmars
Copy link
Contributor

mock is not installed on Python 3.x according to setup.cfg: mock; python_version<"3.0". Import it from stdlib to fix the ImportError.

`mock` is not installed on Python 3.x according to setup.cfg: `mock; python_version<"3.0"`. Import it from stdlib to fix the ImportError.
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #11 (a66c5b2) into master (a1e3459) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   59.89%   59.89%           
=======================================
  Files           6        6           
  Lines         182      182           
=======================================
  Hits          109      109           
  Misses         73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e3459...a66c5b2. Read the comment docs.

Copy link
Collaborator

@p1c2u p1c2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I would just move it to combat module

@p1c2u p1c2u merged commit 185112b into python-openapi:master Mar 26, 2021
@felixonmars felixonmars deleted the patch-1 branch March 26, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants