Drop Python 2.7 and 3.5 support and bump dependency upper bounds #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthagen
approved these changes
Jan 16, 2022
p1c2u
reviewed
Jan 19, 2022
p1c2u
reviewed
Jan 19, 2022
|
@p1c2u I would also suggest to drop support for Python 3.6 and to add suport for Python 3.10 acording to https://endoflife.date/python |
nezhar
reviewed
Jan 24, 2022
.github/workflows/python-test.yml
Outdated
| @@ -14,7 +14,7 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9] | |||
| python-version: [3.7, 3.8, 3.9, 3.10] | |||
There was a problem hiding this comment.
The Python versions should be declared as strings as in the docs of the setup python action, otherwise 3.10 might be interpreted as 3.1 in the workflow.
p1c2u
force-pushed
the
master
branch
3 times, most recently
from
c9e3ed8 to
91a75b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 98.14% 96.24% -1.90%
==========================================
Files 19 19
Lines 538 533 -5
Branches 0 101 +101
==========================================
- Hits 528 513 -15
Misses 10 10
- Partials 0 10 +10
Continue to review full report at Codecov.
|
|
@RobbeSneyders thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130
Fixes #135
jsonschemareleased version 4.0.0 which dropped support for Python 2.7 and 3.5.openapi-spec-validatorshould do the same to support new versions ofjsonschema. Both upstream dependencies and downstream dependents have already upgraded theirjsonschemaversion constraints, which leads to conflicts withopenapi-spec-validator.