fix(completions): add quoting of command names #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
reviewed
Sep 6, 2022
neersighted
approved these changes
Sep 6, 2022
|
I kid you not, I was just coming here to see about contributing the quoting fixes. Thanks @neersighted! |
jeffbyrnes
added a commit
to jeffbyrnes/dotfiles
that referenced
this pull request
Sep 6, 2022
See python-poetry/cleo#247 for the actual upstream fix
deantvv
added a commit
to deantvv/configs
that referenced
this pull request
Oct 5, 2022
remove this when [PR](python-poetry/cleo#247) lands in upstream
deantvv
added a commit
to deantvv/dotfilesboot
that referenced
this pull request
Jan 18, 2024
remove this when [PR](python-poetry/cleo#247) lands in upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#133
Resolves: python-poetry/poetry#153
Resolves: #437
Resolves: python-poetry/poetry#4572
Resolves: python-poetry/poetry#3418
Initial fix to some of the completions issues. I have a refactor of the whole completion system on the way, but since it might take some time, I decided to cut it like this for now, so the shell errors are fixed.