Skip to content

use packaging.utils.canonicalize_name() #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neersighted merged 2 commits into from
Jul 18, 2022
Merged

use packaging.utils.canonicalize_name() #418

neersighted merged 2 commits into from
Jul 18, 2022

Conversation

@dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Jul 17, 2022

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dimbleby
Copy link
Contributor Author

dimbleby commented Jul 17, 2022

Hmm, the "poetry downstream" tests should surely have been broken by this - it removes a method that is used by poetry.

@edgarrmondragon
Copy link
Contributor

edgarrmondragon commented Jul 17, 2022

@dimbleby I guess canonicalize_name is still importable from the core's module because it has the same name.

@neersighted neersighted merged commit 5b4be0d into python-poetry:main Jul 18, 2022
@dimbleby dimbleby deleted the just-one-canonicalize-name branch July 18, 2022 17:24
@finswimmer finswimmer mentioned this pull request Aug 16, 2022
Merged
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
@dimbleby @bostonrwalker
use packaging.utils.canonicalize_name() (python-poetry#418)
d2dd630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neersighted neersighted neersighted approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimbleby @edgarrmondragon @neersighted