Skip to content

Conversation

@radoering
Copy link
Member

@radoering radoering commented Oct 6, 2024

… and refactor code for better maintainability

Related to: python-poetry/poetry#9691
Requires: python-poetry/poetry#9754

  • Added tests for changed code.
  • Updated documentation for changed code. (downstream)

@Secrus
Copy link
Member

Secrus commented Oct 6, 2024

I would still go with include being default only for sdist. It is most often used to include some extra files like docs or tests directories and those should not be placed in site-packages, as it would happen when included in wheels. Inclusion in wheels should be explicit with a note in docs about how it works and what happens when wheel format is used. Default inclusion in wheels is a bug in my eyes and it shouldn't work that way.

@radoering radoering marked this pull request as draft October 6, 2024 17:55
@radoering radoering changed the title make default formats of include consistent ("sdist" and "wheel")… make default formats of include consistent ("sdist" only)… Oct 11, 2024
@radoering
Copy link
Member Author

I would still go with include being default only for sdist.

OK, let's do it. I added a commit to change the default.

@radoering radoering marked this pull request as ready for review October 12, 2024 07:32
@radoering radoering enabled auto-merge (squash) October 13, 2024 20:28
@radoering radoering merged commit 1bdbd90 into python-poetry:main Oct 13, 2024
radoering added a commit to radoering/poetry that referenced this pull request Oct 18, 2024
radoering added a commit to radoering/poetry that referenced this pull request Oct 20, 2024
addict3d added a commit to addict3d/diagrams that referenced this pull request Mar 15, 2025
Poetry's `include` directive defaults to only including files in the sdist.
See python-poetry/poetry-core#773
moroten added a commit to meroton/git-toprepo that referenced this pull request Apr 24, 2025
python-poetry/poetry-core#773 merge 2024-10-13
stopped including "include" files into wheels by default. This update
adds git_filter_repo_for_toprepo.py back into the wheel.

Fixes #38
moroten added a commit to meroton/git-toprepo that referenced this pull request Apr 24, 2025
python-poetry/poetry-core#773 merge 2024-10-13
stopped including "include" files into wheels by default. This update
adds git_filter_repo_for_toprepo.py back into the wheel.

Fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants