Poetry Core: `parse_constraint` can create unparseable max for SingleMarker

[brentropic]

Description

A Python module with Requires-Python: ==3.*,>=3.8.0 is in my lock-space.

Running poetry lock gives me the following message and quits instead of producing a lockfile:
Invalid marker for 'python_full_version': <4.dev0

Minimum repro:

from poetry.core.constraints.version.parser import parse_constraint
constraint = parse_constraint("==3.*,>=3.8.0")
from poetry.core.version.markers import SingleMarker
SingleMarker("python_full_version", constraint.min)
SingleMarker("python_full_version", constraint.max)

poetry.core.constraints.version.exceptions.ParseConstraintError: Could not parse version constraint: 4.dev0.0
...
poetry.core.version.markers.InvalidMarkerError: Invalid marker for 'python_full_version': 4.dev0

Workarounds

Commenting out the following in poetry.core.constraints.version.parser._make_x_constraint_range:

https://github.com/python-poetry/poetry-core/blob/2.1.1/src/poetry/core/constraints/version/parser.py#L248-L251

    if not is_marker_constraint:
        _min = _min.first_devrelease()
        if not _max.is_devrelease():
            _max = _max.first_devrelease()

Not much of a workaround really.

Poetry Installation Method

pipx

Operating System

--

Poetry Version

Poetry (version 2.1.1)

Poetry Configuration

--

Python Sysconfig

sysconfig.log

Paste the output of 'python -m sysconfig', over this line.

Example pyproject.toml

Poetry Runtime Logs

poetry-runtime.log

Paste the output of 'poetry -vvv <command>', over this line.

[brentropic]

Looks like the issue doesn't occur in 2.0.1, but it does occur in 2.1.0.

I hope that helps.

[brentropic]

Looks like commenting this out resolves the issue:

            elif name == "python_full_version" and not swapped_name_value:
                # fix precision of python_full_version marker
                precision = self._value.count(".") + 1
                if precision < 3:
                    suffix = ".0" * (3 - precision)
                    self._value += suffix
                    constraint_string += suffix

https://github.com/python-poetry/poetry-core/blame/2.1.0/src/poetry/core/version/markers.py#L419-L425

Makes sense now, this code will convert 4.dev0 to 4.dev0.0, which isn't a valid version.

@radoering
What is the alternative solution to this? Passing it through the full Version parser and normalising it?

[radoering]

I think I need the call stack of the original error to give an answer.

Can you provide the output of poetry lock -v, especially the traceback? (Or even better a small pyproject.toml to reproduce the issue?)

[brentropic]

  Stack trace:

  3  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:435 in __init__
       433│ 
       434│         try:
    →  435│             parsed_constraint = parser(constraint_string)
       436│         except ParseConstraintError as e:
       437│             raise InvalidMarkerError(

  2  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/constraints/version/parser.py:25 in parse_marker_version_constraint
       23│     constraints: str, *, pep440: bool = True
       24│ ) -> VersionConstraint:
    →  25│     return _parse_constraint(
       26│         constraints=constraints, is_marker_constraint=True, pep440=pep440
       27│     )

  1  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/constraints/version/parser.py:60 in _parse_constraint
       58│         else:
       59│             constraint_objects.append(
    →  60│                 parse_single_constraint(
       61│                     and_constraints[0],
       62│                     is_marker_constraint=is_marker_constraint,

  ParseConstraintError

  Could not parse version constraint: <4.dev0.0

  at ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/constraints/version/parser.py:226 in parse_single_constraint
      222│         if op == "!=":
      223│             return VersionUnion(VersionRange(max=version), VersionRange(min=version))
      224│         return version
      225│ 
    → 226│     raise ParseConstraintError(f"Could not parse version constraint: {constraint}")
      227│ 
      228│ 
      229│ def _make_x_constraint_range(
      230│     version: Version, *, invert: bool = False, is_marker_constraint: bool = False

The following error occurred when trying to handle this error:


  Stack trace:

  24  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/cleo/application.py:327 in run
       325│ 
       326│             try:
     → 327│                 exit_code = self._run(io)
       328│             except BrokenPipeError:
       329│                 # If we are piped to another process, it may close early and send a

  23  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/console/application.py:260 in _run
       258│         with directory(self._working_directory):
       259│             try:
     → 260│                 exit_code = super()._run(io)
       261│             except PoetryRuntimeError as e:
       262│                 io.write_error_line("")

  22  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/cleo/application.py:431 in _run
       429│             io.input.interactive(interactive)
       430│ 
     → 431│         exit_code = self._run_command(command, io)
       432│         self._running_command = None
       433│ 

  21  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/cleo/application.py:473 in _run_command
       471│ 
       472│         if error is not None:
     → 473│             raise error
       474│ 
       475│         return terminate_event.exit_code

  20  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/cleo/application.py:457 in _run_command
       455│ 
       456│             if command_event.command_should_run():
     → 457│                 exit_code = command.run(io)
       458│             else:
       459│                 exit_code = ConsoleCommandEvent.RETURN_CODE_DISABLED

  19  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/cleo/commands/base_command.py:117 in run
       115│         io.input.validate()
       116│ 
     → 117│         return self.execute(io) or 0
       118│ 
       119│     def merge_application_definition(self, merge_args: bool = True) -> None:

  18  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/console/commands/installer_command.py:39 in execute
        37│     def execute(self, io: IO) -> int:
        38│         PoetryKeyring.preflight_check(io, self.poetry.config)
     →  39│         return super().execute(io)
        40│ 

  17  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/cleo/commands/command.py:61 in execute
        59│ 
        60│         try:
     →  61│             return self.handle()
        62│         except KeyboardInterrupt:
        63│             return 1

  16  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/console/commands/lock.py:44 in handle
        42│         self.installer.lock(update=self.option("regenerate"))
        43│ 
     →  44│         return self.installer.run()
        45│ 

  15  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/installation/installer.py:94 in run
        92│         # Check if refresh
        93│         if not self._update and self._lock and self._locker.is_locked():
     →  94│             return self._do_refresh()
        95│ 
        96│         # Force update if there is no lock file present

  14  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/installation/installer.py:183 in _do_refresh
       181│ 
       182│         locked_repository = self._locker.locked_repository()
     → 183│         solver = Solver(
       184│             self._package,
       185│             self._pool,

  13  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/puzzle/solver.py:62 in __init__
        60│         self._io = io
        61│ 
     →  62│         self._provider = Provider(
        63│             self._package,
        64│             self._pool,

  12  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/puzzle/provider.py:144 in __init__
        142│         for package in locked or []:
        143│             self._locked[package.name].append(
     →  144│                 DependencyPackage(package.to_dependency(), package)
        145│             )
        146│         for dependency_packages in self._locked.values():

  11  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/packages/package.py:534 in to_dependency
       532│ 
       533│         if not self.python_constraint.is_any():
     → 534│             dep.python_versions = self.python_versions
       535│ 
       536│         if not self.is_direct_origin():

  10  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/packages/dependency.py:132 in python_versions
       130│         if not self._python_constraint.is_any():
       131│             self._marker = self._marker.intersect(
     → 132│                 parse_marker(
       133│                     create_nested_marker("python_version", self._python_constraint)
       134│                 )

   9  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:995 in parse_marker
        993│     parsed = _parser.parse(marker)
        994│ 
     →  995│     markers = _compact_markers(parsed.children)
        996│ 
        997│     return markers

   8  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:1054 in _compact_markers
       1052│         return MarkerUnion(*sub_markers)
       1053│ 
     → 1054│     return union(*sub_markers)
       1055│ 
       1056│ 

   7  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:1104 in decorated
       1102│         call_args.append(markers)
       1103│         try:
     → 1104│             result = func(*markers)
       1105│         finally:
       1106│             call_args.pop()

   6  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:1150 in union
       1148│         unnormalized = unnormalized.markers[0]
       1149│ 
     → 1150│     conjunction = cnf(unnormalized)
       1151│     if not isinstance(conjunction, MultiMarker):
       1152│         return conjunction

   5  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:1070 in cnf
       1068│ 
       1069│     if isinstance(marker, MultiMarker):
     → 1070│         return MultiMarker.of(*[cnf(m) for m in marker.markers])
       1071│ 
       1072│     return marker

   4  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:657 in of
        655│                     # it'll become another SingleMarker.
        656│                     if isinstance(mark, SingleMarkerLike):
     →  657│                         new_marker = mark.intersect(marker)
        658│                         if new_marker.is_empty():
        659│                             return EmptyMarker()

   3  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:317 in intersect
        315│     def intersect(self, other: BaseMarker) -> BaseMarker:
        316│         if isinstance(other, SingleMarkerLike):
     →  317│             merged = _merge_single_markers(self, other, MultiMarker)
        318│             if merged is not None:
        319│                 return merged

   2  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:1175 in _merge_single_markers
       1173│         assert isinstance(marker1, SingleMarker)
       1174│         assert isinstance(marker2, SingleMarker)
     → 1175│         return _merge_python_version_single_markers(marker1, marker2, merge_class)
       1176│ 
       1177│     if marker1.name != marker2.name:

   1  ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:1250 in _merge_python_version_single_markers
       1248│ 
       1249│     normalized_constraint = get_python_constraint_from_marker(version_marker)
     → 1250│     normalized_marker = SingleMarker("python_full_version", normalized_constraint)
       1251│     merged_marker = _merge_single_markers(
       1252│         normalized_marker, full_version_marker, merge_class

  InvalidMarkerError

  Invalid marker for 'python_full_version': <4.dev0

  at ~/.local/pipx/venvs/poetry/lib/python3.12/site-packages/poetry/core/version/markers.py:437 in __init__
       433│ 
       434│         try:
       435│             parsed_constraint = parser(constraint_string)
       436│         except ParseConstraintError as e:
    →  437│             raise InvalidMarkerError(
       438│                 f"Invalid marker for '{name}': {original_constraint_string}"
       439│             ) from e
       440│ 
       441│         super().__init__(name, parsed_constraint)

[brentropic]

This triggers it for me with poetry lock -vv --regenerate

pyproject.toml

[tool.poetry]
name = "constraint-mwe"
version = "1.0.0"
description = "Desc"
authors = ["Me <example@example.org>"]

[[tool.poetry.packages]]
include = "."

[[tool.poetry.source]]
name = "PyPI"
priority = "primary"

[tool.poetry.dependencies]
python = "~3.12"

boltons = { version = "*", python = "==3.*,>=3.8.0" }

[radoering]

I would say the bug is probably in create_nested_marker(). There is already some special handling for python_version in there.

[brentropic]

Can confirm that applying the changes from the pull request fixes my initial issue, thank you for the prompt attention!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.