Skip to content

config: make normalization of Boolean env vars case-insensitive #10080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radoering merged 1 commit into from
Jan 20, 2025
Merged

config: make normalization of Boolean env vars case-insensitive #10080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/poetry/config/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def boolean_validator(val: str) -> bool:


def boolean_normalizer(val: str) -> bool:
return val in ["true", "1"]
return val.lower() in ["true", "1"]


def int_normalizer(val: str) -> int:
Expand Down
12 changes: 11 additions & 1 deletion tests/config/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,17 @@ def test_config_get_processes_depended_on_values(

def generate_environment_variable_tests() -> Iterator[tuple[str, str, str, bool]]:
data: list[tuple[Normalizer, list[tuple[str, Any]]]] = [
(boolean_normalizer, [("true", True), ("false", False)]),
(
boolean_normalizer,
[
("true", True),
("false", False),
("True", True),
("False", False),
("1", True),
("0", False),
],
),
(int_normalizer, [("4", 4), ("2", 2)]),
]

Expand Down
Loading