fix: only consider package links for sdist and bdist_wheels #5767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
neersighted
force-pushed
the
package-types
branch
from
978690d to
e6b66aa
Compare
neersighted
requested changes
Jun 5, 2022
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
LGTM, but I'd like to see at least one or two regression tests validating this behavior in both find_links_for_package and _get_release_info -- assuming that we can mock those without things getting too tangled.
Member
Author
Done. |
finswimmer
force-pushed
the
package-types
branch
from
50c61c3 to
5a68dd5
Compare
finswimmer
force-pushed
the
package-types
branch
from
5a68dd5 to
b528d1a
Compare
neersighted
added
impact/backport
neersighted
approved these changes
Sep 7, 2022
neersighted
pushed a commit
that referenced
this pull request
Sep 7, 2022
Closed
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only follow and lock links for packages of type
sdistorbdist_wheelin PyPi repository.Closes: #3649
Closes: #4903
(This is a port of #3656.)