Skip to content

Conversation

@reesehyde
Copy link
Contributor

Pull Request Check List

Resolves:

just let me know if I need to make a Poetry issue!

  • Added tests for changed code.
  • Updated documentation for changed code.

Bug

Relative links on Single Page Repositories are not resolved correctly

Steps to Reproduce

For example, take this pyproject.toml to install DGL according to its single-page repo:

[tool.poetry]
package-mode = false

[tool.poetry.dependencies]
python = "^3.10"
dgl = { version = "2.3.0+cu118", source = "dgl" }

[[tool.poetry.source]]
name = "dgl"
url = "https://data.dgl.ai/wheels/torch-2.3/cu118/repo.html"
priority = "explicit"

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

Expected Behavior

  • Poetry installs an appropriate version from the repo.html index page

Actual Behavior

403 Client Error: Forbidden for url: https://data.dgl.ai/wheels/torch-2.3/cu118/repo.html/dgl-2.3.0%2Bcu118-cp310-cp310-manylinux1_x86_64.whl

Poetry tries to locate the dgl-2.3.0+cu118-cp310-cp310-manylinux1_x86_64.whl file at /cu118/repo.html/dgl-2.3.0+cu118-cp310-cp310-manylinux1_x86_64.whl instead of /cu118/dgl-2.3.0+cu118-cp310-cp310-manylinux1_x86_64.whl

@dimbleby
Copy link
Contributor

dimbleby commented Jul 6, 2024

#9166 already fixes this

@radoering
Copy link
Member

I finally merged #9166 so I think we can close this one.

@radoering radoering closed this Jul 7, 2024
@reesehyde
Copy link
Contributor Author

Ah I missed the open PR, thank y'all!

@reesehyde reesehyde deleted the reesehyde/single-page-repo-htmlpage branch July 7, 2024 14:07
@github-actions
Copy link

github-actions bot commented Aug 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants