Skip to content

feat: in show {package} output, clarify meaning of 'required by' entries #9750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Secrus merged 6 commits into from
Oct 14, 2024
Merged

feat: in show {package} output, clarify meaning of 'required by' entries #9750

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff0705b
In `show {package}` output, clarify meaning of 'required by' entries
elliot-100 Oct 10, 2024
65ebc1e
docs: update CLI docs
elliot-100 Oct 10, 2024
049e671
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 10, 2024
42d80c9
Revert addition of package name in `show {package}` `required-by` output
pre-commit-ci[bot] Oct 10, 2024
babb995
Merge branch 'main' into feat/clarify-show-package-required-by-output
elliot-100 Oct 13, 2024
093378d
Merge branch 'main' into feat/clarify-show-package-required-by-output
Secrus Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ dependencies
- pytzdata >=2017.2.2

required by
- calendar >=1.4.0
- calendar requires pendulum >=1.4.0
```

### Options
Expand Down
4 changes: 3 additions & 1 deletion src/poetry/console/commands/show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,9 @@ def _display_single_package_information(
self.line("")
self.line("<info>required by</info>")
for parent, requires_version in required_by.items():
self.line(f" - <c1>{parent}</c1> <b>{requires_version}</b>")
self.line(
f" - <c1>{parent}</c1> requires {package} <b>{requires_version}</b>"
)

return 0

Expand Down
2 changes: 1 addition & 1 deletion tests/console/commands/test_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,7 +1981,7 @@ def test_show_required_by_deps(
- msgpack-python >=0.5 <0.6

required by
- pendulum >=0.2.0 <0.3.0
- pendulum requires cachy >=0.2.0 <0.3.0
""".splitlines()
actual = [line.rstrip() for line in tester.io.fetch_output().splitlines()]
assert actual == expected
Expand Down