Skip to content

Custom swagger filename #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ProgHaj opened this issue Aug 6, 2020 · 5 comments
Open

Custom swagger filename #191

ProgHaj opened this issue Aug 6, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@ProgHaj
Copy link

ProgHaj commented Aug 6, 2020 •
edited
Loading

Currently, when trying to use multiple blueprints with different restx Api's but with the same url_prefix, restx will default to using the same swagger.json file (since it is located in the folder). This makes eg Api(bp1, doc='/docs/internal') and Api(bp2, doc='docs/external') show the same swagger.json file, with only the first blueprint registered to the flask application will being shown (but both routes still works).

I would like to be able to be able to specify my swagger.json filename myself when creating the Api, to be able to have multiple docs for different blueprints under the same url_prefix scope.
@ProgHaj ProgHaj added the enhancement New feature or request label Aug 6, 2020
ProgHaj pushed a commit to ProgHaj/flask-restx that referenced this issue Aug 6, 2020
@MTullbergDebricked
Add default swagger filename to Api, issue 191.
94f2844 
python-restx#191
@ProgHaj ProgHaj mentioned this issue Aug 6, 2020
Merged
ProgHaj pushed a commit to ProgHaj/flask-restx that referenced this issue Sep 29, 2020
@MTullbergDebricked
Add default swagger filename to Api, issue 191.
2bee37e 
python-restx#191
ProgHaj pushed a commit to ProgHaj/flask-restx that referenced this issue Dec 16, 2020
@MTullbergDebricked
Add default swagger filename to Api, issue 191.
de85b9d 
python-restx#191
ProgHaj pushed a commit to ProgHaj/flask-restx that referenced this issue Mar 3, 2021
@MTullbergDebricked
Add default swagger filename to Api, issue 191.
ad4f6f3 
python-restx#191
ProgHaj pushed a commit to ProgHaj/flask-restx that referenced this issue May 12, 2021
@MTullbergDebricked
Add default swagger filename to Api, issue 191.
115a72a 
python-restx#191
@nfickas
Copy link

nfickas commented Jul 27, 2021

I see this has been open for a while, this enhancement would help out my team immensely. Is there anything holding back the associated merge request?

@ProgHaj
Copy link
Author

ProgHaj commented Aug 4, 2021

It would help my team immensely as well. I don't believe anything is holding it back -- just needs a final review from the maintainers.

@nfickas
Copy link

nfickas commented Aug 18, 2021

@ProgHaj looks like #192 needs to be rebased, but looks like it's super close to getting merged in!

ProgHaj pushed a commit to ProgHaj/flask-restx that referenced this issue Aug 30, 2021
@MTullbergDebricked
Add default swagger filename to Api, issue 191.
037fe95 
python-restx#191
@ProgHaj
Copy link
Author

ProgHaj commented Aug 30, 2021

Thanks, rebased!

@j5awry
Copy link
Contributor

j5awry commented Sep 8, 2021

merged #192. If folks can try out from the main branch, please do. we'll try to get release out this quarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ProgHaj @j5awry @nfickas