Skip to content

Allow example=False #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Allow example=False #213

merged 1 commit into from
Sep 1, 2020

Conversation

ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Sep 1, 2020

Currently with a Boolean field it isn't possible to set the example to
'False' since it would instead be set to None.

Fixes #206

Currently with a Boolean field it isn't possible to set the example to
'False' since it would instead be set to None.

Fixes python-restx#206
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          19       19           
  Lines        2697     2697           
=======================================
  Hits         2614     2614           
  Misses         83       83           
Impacted Files Coverage Δ
flask_restx/fields.py 96.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d884f...5d4f74f. Read the comment docs.

@ziirish ziirish merged commit 85706be into python-restx:master Sep 1, 2020
@ogenstad ogenstad deleted the example branch September 1, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean example, unable to set value to False
2 participants