Skip to content

Fixing unregistered nested ordered model bug #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

andre-c-andersen
Copy link
Contributor

When setting ordered=True in a Namespace, nested models are not registered with Swagger giving a "Could not resolve reference" in Swagger documentation. This pull request fixes this.

Related bug reports and pull requests:

When setting `ordered=True` in a Namespace, nested models are not registered with `Swagger` giving a "Could not resolve reference" in Swagger documentation.
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #267 (61cdc3b) into master (b31bd79) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          19       19           
  Lines        2712     2712           
=======================================
  Hits         2627     2627           
  Misses         85       85           
Impacted Files Coverage Δ
flask_restx/swagger.py 96.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31bd79...8692ed7. Read the comment docs.

Copy link
Contributor

@ziirish ziirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@ziirish ziirish merged commit c5b37e2 into python-restx:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants