-
-
Notifications
You must be signed in to change notification settings - Fork 11
Test and work properly on sphinx < 1.7 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and work properly on sphinx < 1.7 #16
Conversation
Also adds testing on 3.7 Fixes python-triogh-15
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 264 267 +3
Branches 42 42
=====================================
+ Hits 264 267 +3
Continue to review full report at Codecov.
|
Add a compatible way in `sphinx==1.6.x`
Update description.
I guess it works fine now :) |
@Sraw oh awesome! ....okay now I'm confused though. Do you know why my first version passed the tests? I forgot to disable the test you added to make sure that the ordering worked, so it should have failed, I think... |
I am confused too. Let me have a look. |
Funny, it works out of the box lol. Seems my modification is redundant. I will dive in further when I am free. |
Huh. Yeah, it is possible that the original bug only affected sphinx 1.7 and we never noticed until now, I could believe that. |
Yep, as our test never covers |
Remove redundant code.
OK that was a lot more confusing than I expected but I think we've got it nailed down now! I was impressed by how quickly you figured out the |
Congratulation :-) |
Also adds testing on 3.7
Fixes gh-15