drop versioneer and use setuptools_scm instead #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Nov 9, 2020
Conengmo
reviewed
Nov 9, 2020
| @@ -92,5 +89,9 @@ def walk_subpkg(name): | |||
| extras_require={"testing": ["pytest"]}, | |||
| install_requires=install_requires, | |||
| zip_safe=False, | |||
| cmdclass=versioneer.get_cmdclass(), | |||
| use_scm_version={ | |||
There was a problem hiding this comment.
I haven't used scm before, so I can't really comment on this. I've been reading some docs, and they say to add setup_requires=['setuptools_scm'], here as well. https://github.com/pypa/setuptools_scm/#setuppy-usage If you're sure that this works as is then let's go ahead.
There was a problem hiding this comment.
That is correct but my next PR would remove it b/c I'm planning on adding a pyproject.toml to make folium pep 517/518 compliant.
There was a problem hiding this comment.
Sounds good, so this is merely an intermediate change. Go ahead then.
Co-authored-by: Frank <[email protected]>
stickler-ci
reviewed
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Conengmo can you review this one and merge before #1409?